-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] txn client: push the txn's snapshot ts #19759
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volgariver6
requested review from
reusee,
XuPeng-SH,
triump2020,
zhangxu19830126 and
daviszhen
as code owners
November 4, 2024 02:39
volgariver6
force-pushed
the
issue19247-2.0
branch
from
November 4, 2024 03:58
437bf15
to
5cfa70e
Compare
volgariver6
force-pushed
the
issue19247-2.0
branch
from
November 4, 2024 04:51
5cfa70e
to
6ab4129
Compare
reusee
approved these changes
Nov 4, 2024
triump2020
approved these changes
Nov 4, 2024
XuPeng-SH
approved these changes
Nov 4, 2024
daviszhen
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #19247
What this PR does / why we need it:
If TN is restarted by some reason, we should check the transactions
which are creating. If the snapshot TS is smaller than ts of catalog,
push the snapshot ts.