fileservice, fifocache: add context params #19766
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reusee
requested review from
XuPeng-SH,
xzxiong,
zhangxu19830126,
m-schen,
ouyuanning,
LeftHandCold,
fengttt,
daviszhen,
qingxinhome and
sukki37
as code owners
reusee
force-pushed
the
perstmtperfcounter
branch
from
bda6b63
to
1e3e891
Compare
reusee
force-pushed
the
perstmtperfcounter
branch
from
ddcdeba
to
d55caaf
Compare
ouyuanning
approved these changes
Nov 6, 2024
xzxiong
approved these changes
Nov 6, 2024
reusee
force-pushed
the
perstmtperfcounter
branch
from
d55caaf
to
a3bbfdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #19765
What this PR does / why we need it:
Add context parameter to fifocache.postGet/Set/Evict to allow perfcounter update in these callbacks.