Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/plan/function: use vector.GetData instead of unsafe.Slice #19832

Closed
wants to merge 1 commit into from
Closed

sql/plan/function: use vector.GetData instead of unsafe.Slice #19832

wants to merge 1 commit into from

Conversation

reusee
Copy link
Contributor

@reusee reusee commented Nov 6, 2024

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #19807

What this PR does / why we need it:

Use vector.GetData to get the data field

@reusee reusee requested a review from m-schen as a code owner November 6, 2024 07:02
@matrix-meow matrix-meow added the size/XS Denotes a PR that changes [1, 9] lines label Nov 6, 2024
@mergify mergify bot added the kind/bug Something isn't working label Nov 6, 2024
@reusee
Copy link
Contributor Author

reusee commented Nov 7, 2024

no longer required since it's fixed in

matrixone/pkg/sql/plan/function/func_builtin.go

Line 1096 in 44ae5a2

fillGroupStr := func(keys [][]byte, vec *vector.Vector, n int, sz int, start int) {

@reusee reusee closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-schen m-schen Awaiting requested review from m-schen m-schen is a code owner

Assignees
No one assigned
Labels
kind/bug Something isn't working size/XS Denotes a PR that changes [1, 9] lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reusee @matrix-meow