Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix full segment #8919

Merged
merged 2 commits into from
Apr 10, 2023
Merged

fix full segment #8919

merged 2 commits into from
Apr 10, 2023

Conversation

aptend
Copy link
Contributor

@aptend aptend commented Apr 10, 2023

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #8871

What this PR does / why we need it:

  • create new appendable segments during appending, avoid index overflowing in a segment

@aptend aptend requested a review from XuPeng-SH as a code owner April 10, 2023 03:28
@mergify mergify bot added the kind/bug Something isn't working label Apr 10, 2023
@aptend aptend mentioned this pull request Apr 10, 2023
Closed
1 task
@matrix-meow matrix-meow added the size/M Denotes a PR that changes [100,499] lines label Apr 10, 2023
@mergify mergify bot merged commit da3a62d into matrixorigin:main Apr 10, 2023
@aptend aptend deleted the fix-overflow branch March 8, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuPeng-SH XuPeng-SH XuPeng-SH approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working size/M Denotes a PR that changes [100,499] lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aptend @XuPeng-SH @matrix-meow