Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bvt case for double-exec in CI ACTION #9956

Closed
wants to merge 2 commits into from

Conversation

xzxiong
Copy link
Contributor

@xzxiong xzxiong commented Jun 9, 2023

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue ##9891 (comment)

What this PR does / why we need it:

fix bvt case result, which will run multi times.

@matrix-meow matrix-meow added the size/S Denotes a PR that changes [10,99] lines label Jun 9, 2023
@mergify mergify bot added the kind/test-ci label Jun 9, 2023
@matrix-meow
Copy link
Contributor

@xzxiong Thanks for your contributions!

Title:

The title of the pull request is clear and concise. It indicates that the pull request is fixing a bug in the CI action related to the bvt case for double-exec.

Body:

The body of the pull request is brief and to the point. It includes the type of PR, the issue number that the PR is fixing, and a brief description of what the PR does and why it is needed. However, it could be improved by providing more details about the bug that is being fixed and how it was identified.

Changes:

The changes made in the pull request are focused on fixing the bvt case for double-exec in the CI action. The changes include modifying the query_tae_table.result and query_tae_table.sql files. The changes made to the query_tae_table.result file include adding a timestamp variable and modifying the select statement to include the timestamp variable. The changes made to the query_tae_table.sql file include adding a timestamp variable and modifying the select statement to include the timestamp variable.

Problem:

  1. Lack of details: The pull request lacks details about the bug that is being fixed and how it was identified. This makes it difficult for other developers to understand the context of the changes being made.

  2. Inconsistent formatting: The changes made to the query_tae_table.result file have inconsistent formatting. Some lines have a space before the "+" sign, while others do not. This inconsistency can make the code harder to read and understand.

Suggestion:

  1. Provide more details: The pull request should provide more details about the bug that is being fixed and how it was identified. This will help other developers understand the context of the changes being made.

  2. Consistent formatting: The changes made to the query_tae_table.result file should have consistent formatting. All lines should have a space before the "+" sign or none of them should have a space. This will make the code easier to read and understand.

Optimization:

There are no optimization suggestions for this pull request.

@xzxiong xzxiong closed this Jun 9, 2023
@xzxiong xzxiong deleted the fix_9891 branch October 24, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/test-ci size/S Denotes a PR that changes [10,99] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants