Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not throw on duplicate close calls #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mxmlnkn
Copy link
Contributor

@mxmlnkn mxmlnkn commented Oct 12, 2024

Especially because there is no closed test method, it should be possible to call close multiple times. Currently, this throws an exception:

PySquashfsImage/__init__.py", line 131, in close
    self._fd.close()
    ^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'close'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant