core/mount: Only remove dirs if unmount succeeded

The detached mount is less likely to fail in our case, but if we see any failure to unmount, we should just skip the removal of directories. Signed-off-by: Rodrigo Campos <[email protected]>
matteopulcini6 · Oct 15, 2024 · b20287b · b20287b
1 parent da660e0
commit b20287b
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/core/mount/mount_linux.go b/core/mount/mount_linux.go
@@ -255,6 +255,7 @@ func doPrepareIDMappedOverlay(lowerDirs []string, usernsFd int) (tmpLowerDirs []
 			// gone (eventually) and we can safely delete the directory too.
 			if err := unix.Unmount(lowerDir, unix.MNT_DETACH); err != nil {
 				log.L.WithError(err).Warnf("failed to unmount temp lowerdir %s", lowerDir)
+				continue
 			}
 			// Using os.Remove() so if it's not empty, we don't delete files in the
 			// rootfs.