Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement support for transient storage #21

Merged
merged 5 commits into from
May 14, 2024
Merged

feat: implement support for transient storage #21

merged 5 commits into from
May 14, 2024

Conversation

montekki
Copy link
Contributor

No description provided.

@montekki montekki requested a review from joonazan as a code owner May 14, 2024 13:50
joonazan
joonazan requested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@joonazan joonazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot approve because we didn't test external snapshots.

The transient storage is zeroed when the bootloader starts the next transaction but I am not sure when exactly that happens.

src/instruction_handlers/context.rs Outdated Show resolved Hide resolved
@montekki montekki merged commit 7e674eb into master May 14, 2024
5 checks passed
@montekki montekki deleted the fvs-pla-890-implement-transient-danksharding branch May 14, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joonazan joonazan joonazan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@montekki @joonazan