Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fvs circuit statistics tracers interface #55

Merged
merged 28 commits into from
Sep 3, 2024
Merged

chore: fvs circuit statistics tracers interface #55

merged 28 commits into from
Sep 3, 2024

Conversation

montekki
Copy link
Contributor

@montekki montekki commented Aug 14, 2024 •
edited
Loading

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via cargo fmt and cargo clippy.

@montekki montekki changed the base branch from master to stable-tracer-interface August 14, 2024 09:51
@montekki montekki changed the title fvs circuit statistics tracers interface chore: fvs circuit statistics tracers interface Aug 14, 2024
joonazan
joonazan reviewed Aug 21, 2024
View reviewed changes
src/decommit.rs Outdated Show resolved Hide resolved
@montekki montekki mentioned this pull request Aug 21, 2024
Closed
joonazan
joonazan reviewed Aug 22, 2024
View reviewed changes
src/decommit.rs Outdated Show resolved Hide resolved
src/instruction_handlers/storage.rs Outdated Show resolved Hide resolved
src/world_diff.rs Outdated Show resolved Hide resolved
src/world_diff.rs Outdated Show resolved Hide resolved
@joonazan joonazan force-pushed the fvs-circuit-statistics-tracers-interface branch from 1fdf1d0 to fbb2005 Compare August 27, 2024 13:37
@montekki montekki marked this pull request as ready for review August 28, 2024 10:01
Base automatically changed from stable-tracer-interface to master August 28, 2024 16:37
@joonazan joonazan force-pushed the fvs-circuit-statistics-tracers-interface branch from 10ed516 to 1855293 Compare August 28, 2024 17:58
joonazan
joonazan requested changes Aug 28, 2024
View reviewed changes
src/instruction_handlers/storage.rs Outdated Show resolved Hide resolved
eravm-stable-interface/src/state_interface.rs Outdated Show resolved Hide resolved
@joonazan joonazan force-pushed the fvs-circuit-statistics-tracers-interface branch 3 times, most recently from 30674a7 to 45c48c8 Compare August 30, 2024 13:06
joonazan
joonazan requested changes Aug 31, 2024
View reviewed changes
Copy link
Contributor

@joonazan joonazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Decommit opcode isn't tested because tests used to pass even though that one incorrectly incremented the storage cycle count.

It may need to record decommit cycles like far call does but hard to say without a test.

slowli
slowli reviewed Sep 3, 2024
View reviewed changes
src/state.rs Outdated Show resolved Hide resolved
src/instruction_handlers/precompiles.rs Outdated Show resolved Hide resolved
src/rollback.rs Show resolved Hide resolved
src/rollback.rs Outdated Show resolved Hide resolved
src/world_diff.rs Outdated Show resolved Hide resolved
src/world_diff.rs Outdated Show resolved Hide resolved
@joonazan joonazan force-pushed the fvs-circuit-statistics-tracers-interface branch from 58cf727 to c727b54 Compare September 3, 2024 11:55
slowli
slowli reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@slowli slowli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a couple of nits (including a previous one regarding RollbackableSet interface), and the obvious question regarding performance, looks good 👍

src/instruction_handlers/common.rs Outdated Show resolved Hide resolved
eravm-stable-interface/src/tracer_interface.rs Show resolved Hide resolved
@joonazan joonazan merged commit 4ef15d4 into master Sep 3, 2024
7 checks passed
@joonazan joonazan deleted the fvs-circuit-statistics-tracers-interface branch September 3, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slowli slowli slowli left review comments

@joonazan joonazan joonazan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@montekki @slowli @joonazan