feat: l2 native token tests #2916
Conversation
… into kl/split-asset-router-support
… into kl/split-asset-router-support
… into kl/split-asset-router-support
… into kl/l2-native-token-support
… into kl/l2-native-token-support
## What ❔ <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk_supervisor fmt` and `zk_supervisor lint`. --------- Co-authored-by: Raid Ateir <[email protected]> Co-authored-by: kelemeno <[email protected]>
… into kl/l2-native-token-support
| @@ -0,0 +1,50 @@ | |||
| sudo rm -rf ./volumes && zk_supervisor clean containers && zk_inception up -o false | |||
There was a problem hiding this comment.
is this script ever used? storing it in .github implies that it is used in CI, but it is not the case
There was a problem hiding this comment.
the contracts commit used here is not the latest one from the branch in contracts
its just system contract hashes, did not bump for that.
is this script ever used? storing it in .github implies that it is used in CI, but it is not the case
I use it for local setup, testing, yes probably this is not the right place, I'll put it in ./bin ?
There was a problem hiding this comment.
Can you discuss it with @Deniallugo? I just don't feel this is something we want to leave committed forever, if it is something we will delete before merging to main, then okay let's keep it here, but it maybe it is helpful for the platform team/toolbox in general
There was a problem hiding this comment.
We already have things like this in sync-layer-stable, but yes will discuss:
https://github.com/matter-labs/zksync-era/blob/sync-layer-stable/bin/start_sync_layer_l3_chain.sh
There was a problem hiding this comment.
He is OOO today, so I messaged him, but I think we can merge before he replies
There was a problem hiding this comment.
why do we need such scripts?
actually zk_supervisor clean containers already removing volumes and adding one another binary for it seems inappropriate
There was a problem hiding this comment.
Tbh I think it is very similar to zki e init --dev . The difference is that it includes GW.
We can either have it as a bash script, or include it into zki e init --dev .
zk_toolbox/crates/zk_inception/src/commands/chain/migrate_from_gateway.rs
Outdated
Show resolved
Hide resolved
zk_toolbox/crates/zk_inception/src/commands/chain/migrate_from_gateway.rs
Show resolved
Hide resolved
What ❔
Why ❔
Checklist
zk fmtandzk lint.