Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement gas relay mode and inclusion data for data attestation #3070

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

QEDK
Copy link

@QEDK QEDK commented Oct 10, 2024

What ❔

This PR adds gas relay API support for gasless submission to the Avail network, it also provides the attestation implementation necessary for data attestation.

Why ❔

Gas relay API support is required for Avail partners that choose to pay in a different token. Data attestation ensures that arbitrary tx data cannot be used for rollup finality and that no data withholding attack can occur.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

Supersedes #2987

Copy link
Contributor

@dimazhornyk dimazhornyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the logic seems good, but let's work on separating the configs/clients so it is always clear which one is used and what config fields are present

core/lib/config/src/configs/da_client/avail.rs Outdated Show resolved Hide resolved
core/lib/protobuf_config/src/secrets.rs Outdated Show resolved Hide resolved
core/node/da_clients/src/avail/client.rs Outdated Show resolved Hide resolved
core/node/da_clients/src/avail/client.rs Outdated Show resolved Hide resolved
core/lib/config/src/configs/da_client/avail.rs Outdated Show resolved Hide resolved
core/node/da_clients/src/avail/client.rs Show resolved Hide resolved
core/node/da_clients/src/avail/client.rs Outdated Show resolved Hide resolved
@QEDK QEDK force-pushed the dz-sync-layer-da-clients-2 branch from 9ddddfb to 0606be1 Compare October 15, 2024 11:24
core/lib/config/src/configs/da_client/avail.rs Outdated Show resolved Hide resolved
core/lib/config/src/configs/da_client/avail.rs Outdated Show resolved Hide resolved
core/lib/env_config/src/da_client.rs Outdated Show resolved Hide resolved
core/lib/env_config/src/da_client.rs Outdated Show resolved Hide resolved
core/lib/protobuf_config/src/proto/config/da_client.proto Outdated Show resolved Hide resolved
core/lib/protobuf_config/src/da_client.rs Outdated Show resolved Hide resolved
core/lib/protobuf_config/src/secrets.rs Outdated Show resolved Hide resolved
core/node/da_clients/src/avail/client.rs Outdated Show resolved Hide resolved
core/node/da_clients/src/avail/sdk.rs Outdated Show resolved Hide resolved
core/node/da_clients/src/avail/sdk.rs Outdated Show resolved Hide resolved
contracts Outdated Show resolved Hide resolved
@dimazhornyk dimazhornyk added this pull request to the merge queue Oct 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2024
@dimazhornyk dimazhornyk added this pull request to the merge queue Oct 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2024
@dimazhornyk dimazhornyk added this pull request to the merge queue Oct 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants