Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: unify fmt check #3159

Merged
merged 4 commits into from
Oct 23, 2024
Merged

ci: unify fmt check #3159

merged 4 commits into from
Oct 23, 2024

Conversation

perekopskiy
Copy link
Contributor

What ❔

prover ci should check formatting with zkstack_cli

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@perekopskiy perekopskiy requested a review from a team as a code owner October 23, 2024 14:10
EmilLuta
EmilLuta previously approved these changes Oct 23, 2024
View reviewed changes
yorik
yorik previously approved these changes Oct 23, 2024
View reviewed changes
@perekopskiy perekopskiy dismissed stale reviews from yorik and EmilLuta via 4d03b29 October 23, 2024 15:19
@perekopskiy perekopskiy added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 4629450 Oct 23, 2024
30 checks passed
@perekopskiy perekopskiy deleted the unify-fmt-check branch October 23, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorik yorik yorik approved these changes

@EmilLuta EmilLuta EmilLuta left review comments

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 is a code owner automatically assigned from matter-labs/devops

@artmakh artmakh Awaiting requested review from artmakh artmakh is a code owner automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere is a code owner automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

@otani88 otani88 Awaiting requested review from otani88 otani88 is a code owner automatically assigned from matter-labs/devops

@iluwaa iluwaa Awaiting requested review from iluwaa iluwaa is a code owner automatically assigned from matter-labs/devops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@perekopskiy @yorik @EmilLuta