[MM-58455] Add error handling when FocusStatus is not authorized on macOS #3053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amyblais I'm looking to do a dot release for this one if possible. |
Ok 👍 |
amyblais
added
the
CherryPick/Approved
marianunez
reviewed
Jun 6, 2024
src/main/notifications/index.ts
Outdated
| @@ -27,6 +27,11 @@ class NotificationManager { | |||
| private upgradeNotification?: NewVersionNotification; | |||
| private restartToUpgradeNotification?: UpgradeNotification; | |||
|
|
|||
| constructor() { | |||
| // Run this very early to perform an early permission check | |||
| getDoNotDisturb(); | |||
There was a problem hiding this comment.
Will this trigger a permission modal before getting a notification?
There was a problem hiding this comment.
Yes, it shows the macOS one that people were missing.
hmhealey
reviewed
Jun 6, 2024
src/main/notifications/index.ts
Outdated
| @@ -27,6 +27,11 @@ class NotificationManager { | |||
| private upgradeNotification?: NewVersionNotification; | |||
| private restartToUpgradeNotification?: UpgradeNotification; | |||
|
|
|||
| constructor() { | |||
| // Run this very early to perform an early permission check | |||
| getDoNotDisturb(); | |||
There was a problem hiding this comment.
Should this happen as an explicit call from somewhere in the initialization code? It feels a bit weird to have this be a side effect of importing this file
There was a problem hiding this comment.
Yeah I guess that would be better, I wanted to keep everything centralized but the import case does make that a bit awkward.
marianunez
approved these changes
Jun 6, 2024
hmhealey
approved these changes
Jun 6, 2024
devinbinnie
added
4: Reviews Complete
|
Cherry pick is scheduled. |
mattermost-build
added
CherryPick/Done
devinbinnie
added a commit
that referenced
this pull request
Jun 6, 2024
…acOS (#3053) (#3054) * [MM-58455] Add error handling when FocusStatus is not authorized on macOS * Do the permission check very early so that it's less likely for users to miss it * Move permissions check to initialize (cherry picked from commit d11752e) Co-authored-by: Devin Binnie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A recent change that allowed the macOS app to correctly use the
FocusStatusto prevent notifications under DND was completely stopping notifications if permission wasn't given. This was caused by the app not performing any error handling from the DND check, which would throw an error if the app wasn't authorized to check the status.This PR adds that error handling, and logs a warning in the logs to denote that the check failed.
Ticket Link
Closes #3052
https://mattermost.atlassian.net/browse/MM-58455