-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(e2e): Verify Test Notification on Desktop #3162
base: master
Are you sure you want to change the base?
Conversation
Here are the test results below: Test Summary for Linux on commit 5e76ce1New failed tests found on Linux:
The following known failed tests have been fixed on Linux: Test Summary for macOS on commit 5e76ce1New failed tests found on macOS:
The following known failed tests have been fixed on macOS: |
Here are the test results below: Test Summary for Linux on commit 2759c14New failed tests found on Linux:
The following known failed tests have been fixed on Linux: Test Summary for macOS on commit 2759c14New failed tests found on macOS:
The following known failed tests have been fixed on macOS: |
Here are the test results below: Test Summary for Linux on commit 37ccff3New failed tests found on Linux:
The following known failed tests have been fixed on Linux: Test Summary for macOS on commit 37ccff3New failed tests found on macOS:
The following known failed tests have been fixed on macOS: |
Here are the test results below: Test Summary for Linux on commit 37ccff3New failed tests found on Linux:
The following known failed tests have been fixed on Linux: Test Summary for macOS on commit 37ccff3The following known failed tests have been fixed on macOS: |
Here are the test results below: Test Summary for Linux on commit 831ad45New failed tests found on Linux:
The following known failed tests have been fixed on Linux: Test Summary for macOS on commit 831ad45New failed tests found on macOS:
The following known failed tests have been fixed on macOS: |
Here are the test results below: Test Summary for Linux on commit 831ad45New failed tests found on Linux:
The following known failed tests have been fixed on Linux: Test Summary for macOS on commit 831ad45New failed tests found on macOS:
The following known failed tests have been fixed on macOS: |
Here are the test results below: Test Summary for Linux on commit ee013e1New failed tests found on Linux:
The following known failed tests have been fixed on Linux: Test Summary for macOS on commit ee013e1New failed tests found on macOS:
The following known failed tests have been fixed on macOS: Test Summary for Windows on commit ee013e1New failed tests found on Windows:
The following known failed tests have been fixed on Windows: |
@@ -31,7 +31,7 @@ const downloadsLocation = path.join(userDataDir, 'Downloads'); | |||
const boundsInfoPath = path.join(userDataDir, 'bounds-info.json'); | |||
const appUpdatePath = path.join(userDataDir, 'app-update.yml'); | |||
const exampleURL = 'http://example.com/'; | |||
const mattermostURL = process.env.MM_TEST_SERVER_URL || 'http://localhost:8065/'; | |||
const mattermostURL = 'https://mattermost-pr-28334.test.mattermost.cloud/'; // process.env.MM_TEST_SERVER_URL || 'http://localhost:8065/'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this wasn't intended to be merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah @devinbinnie .
sorry, I should have added a note. I'll remove it once the Dev PR gets into master
@@ -266,8 +266,8 @@ module.exports = { | |||
await window.waitForSelector('#input_password-input'); | |||
await window.waitForSelector('#saveSetting'); | |||
|
|||
await window.type('#input_loginId', process.env.MM_TEST_USER_NAME); | |||
await window.type('#input_password-input', process.env.MM_TEST_PASSWORD); | |||
await window.type('#input_loginId', 'sysadmin'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Added the "Do not merge" label due to the outstanding "unrelated changes".
Waiting on Dev PR to merge: mattermost/mattermost#28334