Added an option to return drop_index #194
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Hi @andrejmuhic ! Thanks so much for taking time to submit a patch. I have a proposal for a simpler implementation that doesn't add cruft to the model spec or require separate entry methods in PR #197 . Let me know if it is fit for your purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that there is no way currently to retrieve drop_index in case of na_action='drop'
I did minimal work to add this option.
I decided to pass it through kwargs and did special handling of return_drop_index keyword argument through the pipeline.
Another option would be to attach this to ModelSpec(s) itself but that seems dubious and not the right place logically.