shared_schemes rule

Package.resolved

@@ -49,8 +49,8 @@
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/tuist/XcodeProj",
       "state" : {
-        "revision" : "a3e5d54f8c8a2964ee54870fda33b28651416581",
-        "version" : "8.17.0"
+        "revision" : "e29e0db843062f5157f77d5b68f237eb5aa43f12",
+        "version" : "8.18.0"
       }
     },
     {

README.md

@@ -53,6 +53,7 @@ opt_in_rules:
   - targets_use_xcconfig      # checks for any targets without a XCConfig file set
   - projects_use_xcconfig     # checks for any projects without a XCConfig file set
   - shared_scheme_skips_tests # checks for any shared schemes that have disabled tests
+  - shared_schemes            # checks that all targets have a shared scheme present
 
 # Other rules make sense for all projects by default. You must opt-out of those.
 disabled_rules:

Sources/XCLinting/Rules/HasSharedSchemeRule.swift

@@ -0,0 +1,37 @@
+import Foundation
+
+import XcodeProj
+import XCConfig
+
+/// Ensure that targets have a shared scheme on disk.
+struct SharedSchemesRule {
+	func run(_ environment: XCLinter.Environment) throws -> [Violation] {
+		let sharedSchemesURL = environment
+			.projectRootURL
+			.appendingPathComponent("xcshareddata/xcschemes", isDirectory: true)
+			.standardizedFileURL
+
+		let fileManager = FileManager.default
+
+		guard fileManager.isReadableFile(atPath: sharedSchemesURL.path) else {
+			return [.init("Shared scheme directory not found")]
+		}
+
+		let schemes = Set(try fileManager.contentsOfDirectory(atPath: sharedSchemesURL.path))
+
+		var violations = [Violation]()
+
+		// check targets
+		environment.project.pbxproj.enumerateBuildConfigurations { name, configList in
+			let schemeName = name + ".xcscheme"
+
+			if schemes.contains(schemeName) {
+				return
+			}
+
+			violations.append(.init("No shared scheme found for \"\(name)\""))
+		}
+
+		return violations
+	}
+}

Sources/XCLinting/XCLinter.swift

@@ -84,5 +84,6 @@ extension XCLinter {
 		"projects_use_xcconfig": { try ProjectsUseXCConfigRule().run($0) },
 		"shared_scheme_skips_tests": { try SharedSchemeSkipsTestsRule().run($0) },
 		"relative_paths": { try RelativePathsRule().run($0) },
+		"shared_schemes": { try SharedSchemesRule().run($0) },
 	]
 }

Tests/XCLintTests/SharedSchemesRuleTests.swift

@@ -0,0 +1,38 @@
+import XCTest
+
+@testable import XCLinting
+import XcodeProj
+
+final class SharedSchemesRuleTests: XCTestCase {
+	func testProjectWithSharedSchemes() throws {
+		let url = try Bundle.module.testDataURL(named: "StockMacOSApp.xcodeproj")
+
+		let project = try XcodeProj(pathString: url.path)
+
+		let env = XCLinter.Environment(
+			project: project,
+			projectRootURL: url,
+			configuration: Configuration()
+		)
+
+		let violations = try SharedSchemesRule().run(env)
+
+		XCTAssertTrue(violations.isEmpty)
+	}
+
+	func testProjectWithMissingSharedSchemes() throws {
+		let url = try Bundle.module.testDataURL(named: "SchemeSkipsTests.xcodeproj")
+
+		let project = try XcodeProj(pathString: url.path)
+
+		let env = XCLinter.Environment(
+			project: project,
+			projectRootURL: url,
+			configuration: Configuration()
+		)
+
+		let violations = try SharedSchemesRule().run(env)
+
+		XCTAssertFalse(violations.isEmpty)
+	}
+}