Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acutally read the -d DESTINATION and -a ARCH arguments #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dotysan
Copy link

@dotysan dotysan commented Jun 12, 2022

Needed trailing colon (:) for those args.

@kumadee
Copy link

kumadee commented Jul 5, 2023

@mattolenik Could you please merge this?

@kumadee
Copy link

kumadee commented Jul 5, 2023

Please ignore my above comment.

To others who come here, please take a look at https://github.com/hashicorp/hcl/tree/main/cmd/hcldec as an alternative.

@mvk
Copy link

mvk commented Sep 19, 2023

@mattolenik , the PR looks correct, getopts needs : after the options followed by OPTARG, meaning the diff should show:

diff --git a/install.sh b/install.sh
index b6fc803..8e00db5 100755
--- a/install.sh
+++ b/install.sh
@@ -46,7 +46,7 @@ platform_check() {
 main() {
   platform_check

-  while getopts ":qhdao:" opt; do
+  while getopts ":qhd:a:o:" opt; do
     case $opt in
       q) QUIET=true ;;
       d) DESTINATION="$OPTARG" ;;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants