-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory Consumption #105
Memory Consumption #105
Conversation
Do not merge it. I am using this PR as a playground. |
@davisjam this simple commit prints some memory consumption after analyzing 1k commits in Rails. It prints the memory consumption in the console, so we can see it from Travis. Although definitely not scientific, it will give us a first impression of the differences:
This is what we get now (82 to 558MB). This is quite a lot, actually. We should try and see how the features we implemented to reduce the consumption work. For now, I think I'll merge this into master. Then, in your PR, you rebase it, and we wait for Travis to tell us the memory. What do you think? |
Nice job, this will be a useful way to evaluate memory overheads. The 558MB is presumably because I'm confused about why your visitor finds different amounts of memory used at different times. In |
@davisjam, not really... My best guess is that the list of Maybe the best thing is to plot an histogram, because hopefully the GC works from times to times. Makes sense? |
You could also run the GC before you collect your memory statistics. |
4ec77fe: Useful, but I think you should also run the GC for a precise value. |
That will be the next test! |
As we see, GC works like hell. :) I do not know how to explain the two blocks... maybe the GC learned something, and improved? But still, we can plot the same chart for your branch. Can you merge it there, @davisjam ? |
This PR focuses on writing a memory consumption test for RepoDriller. This way we can measure the impact of our changes in terms of memory usage.