Add more video streaming info #2231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tbago
commented
Feb 23, 2024
tbago
commented
- unify the camera and camera server stream info;
- support multi camera video stream info;
- add camera video stream info usage example;
tbago
commented
Feb 23, 2024
| @@ -506,11 +506,6 @@ Camera::Result CameraImpl::stop_video() | |||
| { | |||
| auto cmd_stop_video = make_command_stop_video(); | |||
|
|
|||
| { | |||
There was a problem hiding this comment.
stop video just mean stop recording video to file, so not need stop video streaming.
tbago
force-pushed
the
add_video_stream_info
branch
2 times, most recently
from
9e9c4bc
to
502619b
Compare
* unify the camera and camera server stream info; * support multi camera video stream info; * add camera video stream info usage example;
tbago
force-pushed
the
add_video_stream_info
branch
from
502619b
to
02853b2
Compare
* unify camera information in camera and camera server; * add camera cap flags in camera and camera server; * add basic example about camera information;
tbago
commented
Feb 27, 2024
|
|
||
| for (const auto& elem : information.camera_cap_flags()) { | ||
| obj.camera_cap_flags.push_back(translateFromRpcCameraCapFlags( | ||
| static_cast<mavsdk::rpc::camera::Information::CameraCapFlags>(elem))); |
There was a problem hiding this comment.
the auto generate code is static_castmavsdk::rpc::camera::CameraCapFlags missing Information domain. I just manual add Information in auto generate code.
tbago
commented
Feb 27, 2024
| @@ -169,6 +261,11 @@ class CameraServerServiceImpl final : public rpc::camera_server::CameraServerSer | |||
|
|
|||
| obj.definition_file_uri = information.definition_file_uri(); | |||
|
|
|||
| for (const auto& elem : information.camera_cap_flags()) { | |||
| obj.camera_cap_flags.push_back(translateFromRpcCameraCapFlags( | |||
| static_cast<mavsdk::rpc::camera_server::Information::CameraCapFlags>(elem))); | |||
There was a problem hiding this comment.
the auto generate code is static_castmavsdk::rpc::camera_server::CameraCapFlags missing Information domain. I just manual add Information in auto generate code.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.