Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nlohmann json submodule and add header directly instead #10

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

bkueng
Copy link
Member

@bkueng bkueng commented Aug 21, 2024

Tested with MAVSDK, and it still builds with this PR.

- There were random git submodule checkout errors in MAVSDK CI for that
  repo. It's not clear why, but a reason could be that the repo is large.
- One of the repo file names is too long and causes failures on Windows 10.
  mavlink/qgroundcontrol#11747
@bkueng bkueng merged commit 7c17207 into main Aug 22, 2024
1 check passed
@bkueng bkueng deleted the json_rm_submodule branch August 22, 2024 05:38
@julianoes
Copy link

Thanks @bkueng!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants