Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Wi-Fi settings #900

Closed
wants to merge 6 commits into from
Closed

Add support for Wi-Fi settings #900

wants to merge 6 commits into from

Conversation

vldpro
Copy link

@vldpro vldpro commented May 4, 2018

In this PR I propose to add new messages to setup Wi-Fi of the vehicle using GCS.

Description:
Vehicle can be in 2 states: connected to a selected network (Client mode) or create its own AP (Access Point). Vehicle will have a list of saved (by user) networks to which it may try to connect. If vehicle can't connect to any network then it will start in AP mode.

Communication with GCS (Initially vehicle is in AP):

  • GCS requests wifi status (MAV_CMD_GET_WIFI_STATUS)
  • GCS requests for number of saved networks (MAV_CMD_GET_WIFI_NETWORKS_COUNT, WIFI_NETWORKS_COUNT)
  • GCS requests for networks info (MAV_CMD_GET_WIFI_NETWORKS_INFO, WIFI_NETWORS_INFO)
  • User connects Vehicle to a selected network (WIFI_NETWORK_CONNECT)
  • Vehicle switches to Client Mode
  • After that user can connect to Vehicle again through WiFi

Additionally, GCS can:

  • Start vehicle in AP mode using MAV_CMD_WIFI_START_AP command.
  • Add new network (SSID, protocol, password) to saved networks using WIFI_NETWORK_ADD message.
  • Delete selected network from saved networks using WIFI_NETWORK_DELETE message.

Also GCS can use messages MAV_CMD_GET_WIFI_NETWORKS_INFO, WIFI_NETWORKS_INFO, MAV_CMD_GET_WIFI_NETWORKS_COUNT, WIFI_NETWORKS_COUNT for obtaining list of scanned networks (Networks which are available for connection)

AlexeyBulatov and others added 5 commits May 4, 2018 15:37
- MAV_CMD_GET_WIFI_NETWORKS_COUNT is used for obtaining Wi-Fi networks (scanned or saved) count with WIFI_NETWORKS_COUNT as reply from vehicle.

- MAV_CMD_GET_WIFI_NETWORKS_INFO is used for retrieving information (SSID/Security type) about saved/scanned networks with WIFI_NETWORK_INFO as reply from vehicle.
- WIFI_STATE - set of wifi states (Client/AP/Undefined)

- MAV_CMD_GET_WIFI_STATUS is used for obtaining information about current Wi-Fi status with WIFI_STATUS as reply.
- Add WIFI_NETWORK_ADD, WIFI_NETWORK_DELETE - add or delete saved Wi-Fi network from vehicle.

- WIFI_NETWORK_CONNECT - connect vehicle to a specified Wi-Fi network (After this message, vehicle switches to Client mode)

- MAV_CMD_WIFI_START_AP - switches vehicle to Access Point mode
@TSC21
Copy link
Member

TSC21 commented May 4, 2018

Is there an RFC open for this? https://mavlink.io/en/contributing/contributing.html

@vldpro
Copy link
Author

vldpro commented May 5, 2018

Sorry for delay, I'll open it soon.

- add WIFI_ACK - response to all messages, which is sent by GCS (excluding commands).
@vldpro
Copy link
Author

vldpro commented May 7, 2018

RFC is created

@hamishwillee
Copy link
Collaborator

Associated RFC has stalled for more than 6 months, with an end status that it may not make sense to implement at all, but definitely should be done differently. I am therefore closing this - it can be reopened (if that makes sense) when the RFC converges on agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants