Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 0012 - MAVLink Standard Testing Suite #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bkueng
Copy link
Member

@bkueng bkueng commented Nov 20, 2018

This is not an RFC for a MAVLink protocol change, but rather it's something that
affects the MAVLink ecosystem. Which is why I'm still opening an RFC here.

Goals

  1. Provide a test suite that can be run against a MAVLink-enabled
    component/system to test if that component or system behaves in accordance to
    the MAVLink standard.
    The focus is on the MAVLink protocol and its microservices (as opposed to
    testing if a mission uploaded via MAVLink is executed by the vehicle as
    expected).
  2. Provide a generic diagnostics tool to check the MAVLink-related health of a
    system (for example which components are active in a network).

The text here is based off a Google doc, and I copied the text to the RFC since it's easier to comment via github.
The Google doc should be the main reference though.

@bkueng bkueng changed the title RFC 0011 - MAVLink Standard Testing Suite RFC 0012 - MAVLink Standard Testing Suite Nov 20, 2018
@bkueng bkueng force-pushed the mavlink_standard_testing_suite branch from b1fb5f4 to 9e2fa4a Compare November 20, 2018 18:21
@thomasgubler
Copy link

This should be discussed int the mavlink call 11/28

@hamishwillee

@hamishwillee
Copy link
Collaborator

@auturgy
Copy link

auturgy commented Nov 26, 2018

@stephendade would be good to get your input here.

@stephendade
Copy link

Thanks @auturgy,

(I've been slowly writing unit tests for the Ardupilot pymavlink as context)

My notes:
-Implementation in Python would lower the risk of cross platform issues (particularly Windows)
-User should be able to select desired Mavlink dialect and version to test against
-Your idea of a compliance report is nice. Makes it easy for manufacturers/developers.

@bkueng
Copy link
Member Author

bkueng commented Nov 27, 2018

Thanks @stephendade. I agree with these points, however the main focus is on the common MAVLink spec. I think this is generally preferable to avoid that MAVLink splits into too many dialects (as it decreases interoperability).
Nonetheless I think it should be possible & easy to add support for different dialects or custom MAVLink messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants