Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Refactor document md to pdf function #70

Closed
ollyhensby opened this issue Nov 5, 2024 · 0 comments · Fixed by #71
Closed

♻️ Refactor document md to pdf function #70

ollyhensby opened this issue Nov 5, 2024 · 0 comments · Fixed by #71
Assignees
@ollyhensby
Labels
enhancement New feature or request

Comments

@ollyhensby
Copy link
Contributor

Describe the upkeep / improvement you'd like to see
Revise the parameter inputs as it isn't that clear what fpth_md currently.

I think that it would be better as md_content which will be string instead.

What aspect of the repo is it likely to impact?
The tests will be affected and aecschedule repo will be also.
@ollyhensby ollyhensby added the enhancement New feature or request label Nov 5, 2024
@ollyhensby ollyhensby self-assigned this Nov 5, 2024
@ollyhensby ollyhensby linked a pull request Nov 5, 2024 that will close this issue
♻ Refactor document_issue_md_to_pdf function #71
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ollyhensby ollyhensby

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

♻ Refactor document_issue_md_to_pdf function maxfordham/document-issue
1 participant
@ollyhensby