Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻ Refactor document_issue_md_to_pdf function #71

Merged
merged 4 commits into from
Nov 6, 2024
Merged

♻ Refactor document_issue_md_to_pdf function #71

merged 4 commits into from
Nov 6, 2024

Conversation

ollyhensby
Copy link
Contributor

Revised the document_issue_md_to_pdf function and created generate_document_issue_pdf which has clearer inputs.

@ollyhensby ollyhensby linked an issue Nov 5, 2024 that may be closed by this pull request
♻️ Refactor document md to pdf function #70
Closed
jgunstone
jgunstone approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@jgunstone jgunstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree this is much clearer.
nice one

@jgunstone jgunstone merged commit 5a38a1f into main Nov 6, 2024
1 check passed
@jgunstone jgunstone deleted the 70-refactor-document-md-to-pdf-function branch November 6, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgunstone jgunstone jgunstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

♻️ Refactor document md to pdf function
2 participants
@ollyhensby @jgunstone