Skip to content

Commit

Permalink
Use simpler workaround for Homebrew directory change
Browse files Browse the repository at this point in the history
  • Loading branch information
oschwald committed Apr 30, 2024
1 parent cb3cca9 commit a3d1877
Showing 1 changed file with 7 additions and 24 deletions.
31 changes: 7 additions & 24 deletions .github/workflows/test-libmaxminddb.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,36 +44,19 @@ jobs:
run: sudo apt install libmaxminddb-dev
if: matrix.platform == 'ubuntu-latest'

- name: "Work around macos arm64 homebrew directory changes"
if: runner.os == 'macos' and runner.arch = 'arm64'
run: |
echo "CFLAGS=-I/opt/homebrew/include" >> $env:GITHUB_ENV
echo "LDFLAGS=-L/opt/homebrew/lib" >> $env:GITHUB_ENV
- name: Install libmaxminddb
run: brew install libmaxminddb && brew ls --verbose libmaxminddb
if: matrix.platform == 'macos-latest'

- name: Build with Werror and Wall (not macOS)
run: python setup.py build
if: matrix.platform != 'macos-latest'
env:
CFLAGS: "-Werror -Wall -Wextra"
CFLAGS: "${{ env.CFLAGS }} -Werror -Wall -Wextra"

- name: Test with tox (system libmaxminddb)
run: tox
if: matrix.platform != 'macos-latest'

# Starting at the end of April 2024, the homebrew include and lib
# directories were not properly set up in the flags for the GitHub
# images. I looked for an issue both in Homebrew and actions/runner-images
# and did not find one or similar reports from other users. Setting
# them here seemed easier than digging into it further. It would
# probably be worth trying to remove this in the future.
- name: Build with Werror and Wall (macOS)
run: python setup.py build
if: matrix.platform == 'macos-latest'
env:
CFLAGS: "-Werror -Wall -Wextra -I/opt/homebrew/include"
LDFLAGS: "-L/opt/homebrew/lib"

- name: Test with tox (system libmaxminddb)
run: tox
if: matrix.platform == 'macos-latest'
env:
CFLAGS: "-I/opt/homebrew/include"
LDFLAGS: "-L/opt/homebrew/lib"

0 comments on commit a3d1877

Please sign in to comment.