Skip to content

Commit

Permalink
Set include and link dirs explicitly for macOS
Browse files Browse the repository at this point in the history
  • Loading branch information
oschwald committed Apr 29, 2024
1 parent e7752d3 commit cadf1f3
Showing 1 changed file with 16 additions and 2 deletions.
18 changes: 16 additions & 2 deletions .github/workflows/test-libmaxminddb.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,27 @@ jobs:
if: matrix.platform == 'ubuntu-latest'

- name: Install libmaxminddb
run: brew install libmaxminddb
run: brew install libmaxminddb && brew ls --verbose libmaxminddb
if: matrix.platform == 'macos-latest'

- name: Build with Werror and Wall
- name: Build with Werror and Wall (not macOS)
run: python setup.py build
if: matrix.platform != 'macos-latest'
env:
CFLAGS: "-Werror -Wall -Wextra"

# Starting at the end of April 2024, the homebrew include and lib
# directories were not properly set up in the flags for the GitHub
# images. I looked for an issue both in Homebrew and actions/runner-images
# and did not find one or similar reports from other users. Setting
# them here seemed easier than digging into it further. It would
# probably be worth trying to remove this in the future.
- name: Build with Werror and Wall (macOS)
run: python setup.py build
if: matrix.platform == 'macos-latest'
env:
CFLAGS: "-Werror -Wall -Wextra -I/opt/homebrew/include"
LDFLAGS: "-L/opt/homebrew/lib"

- name: Test with tox (system libmaxminddb)
run: tox

0 comments on commit cadf1f3

Please sign in to comment.