Set include and link dirs explicitly for macOS

[oschwald]

No description provided.

[ugexe]

I don't know if its necessarily a better strategy, but one pattern I've used for platform specific github action workarounds is to set environment variables for specific platforms. Something like:

- name: "Work around macos arm64 homebrew directory changes"
  if: runner.os == 'macos' and runner.arch = 'arm64'
  run: |
    echo "CFLAGS=-I/opt/homebrew/include" >> $env:GITHUB_ENV
    echo "LDFLAGS=-L/opt/homebrew/lib" >> $env:GITHUB_ENV

- name: Build with Werror and Wall
    run: python setup.py build
    env:
      CFLAGS: "${{ env.CFLAGS }} -Werror -Wall -Wextra"

- name: Test with tox (system libmaxminddb)
    run: tox

[oschwald]

That does seem a bit cleaner. I can try doing that.

[ugexe]

This might have to be macOS and ARM64 actually

[oschwald]

It seems like it worked. 🤷

[ugexe]

Yeah I'm confused. I guess the workflow file being invalid doesn't show as a failure? It should be

if: runner.os == 'macOS' && runner.arch == 'ARM64'

See Annotations from https://github.com/maxmind/MaxMind-DB-Reader-python/actions/runs/8897863643

[Invalid workflow file: .github/workflows/test-libmaxminddb.yml#L48](https://github.com/maxmind/MaxMind-DB-Reader-python/actions/runs/8897863643/workflow)
The workflow is not valid. .github/workflows/test-libmaxminddb.yml (Line: 48, Col: 13): Unexpected symbol: 'and'. Located at position 22 within expression: runner.os == 'macos' and runner.arch = 'arm64'

[oschwald]

Oh, I would have expected some indication that failed in the build statuses or via email. I'll fix that up.

[ugexe]

Also runner.arch = -> runner.arch ==

[ugexe]

Hmmm. I found actions/runner-images#9266 (reply in thread) which mentions:

The problem is that while this maps on X64 for some reason the runner images use the lowercase arm64 rather than following the convention with ARM64. Perhaps this is the issue that needs fixing instead?

So maybe it does need to be arm64, unlike what is mentioned on https://docs.github.com/en/actions/learn-github-actions/variables 😞

[oschwald]

So maybe it does need to be arm64

I am not sure that is the issue. That seems to be running. I thought it might be $env:GITHUB_ENV vs "$GITHUB_ENV", which is mentioned here, but that didn't seem to help.

Edit: actually it was that. I just introduced an unrelated change accidentally.

[ugexe]

The (not macOS) can be removed

[oschwald]

Thanks! I force-pushed it as a single commit to reduce the commit noise.