Faff/Dont delete other instances #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug: use instance_config for IDs
matt-horwood-mayden
requested review from
BenMayden,
cocojamb0,
HiredMussel,
SMMayden and
tdmayden
as code owners
cocojamb0
approved these changes
Nov 8, 2024
|
I'd like to know why this is working before merge (more out of curiosity and not knowing what this is doing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug: use instance_config for IDs
This will now use an empty array, instead of an empty object to work out if there is anything to do. If the array is empty, skip the destroy instance task. As there is a bug in the module that will delete all instances if the IDs is empty