Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for PHP < 7.4 #160

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Drop support for PHP < 7.4 #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85d99fb
Drop support for PHP < 7.4
mmoll Sep 30, 2020
72ea0d0
add some stuff
mmoll Oct 1, 2020
2ddc358
yo
mmoll Aug 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions MO4/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@
<rule ref="SlevomatCodingStandard.Classes.ModernClassNameReference"/>
<!-- report invalid format of inline phpDocs with @var -->
<rule ref="SlevomatCodingStandard.Commenting.InlineDocCommentDeclaration"/>
<!-- TODO -->
<rule ref="SlevomatCodingStandard.Commenting.UselessFunctionDocComment"/>
<!-- Forbid useless @inheritDoc comments -->
<rule ref="SlevomatCodingStandard.Commenting.UselessInheritDocComment"/>
<!-- Forbid assignments in conditions -->
Expand All @@ -129,6 +131,10 @@
<rule ref="SlevomatCodingStandard.ControlStructures.NewWithParentheses"/>
<!-- Require usage of null coalesce operator when possible -->
<rule ref="SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator"/>
<!-- Require usage of null coalesce equal operator when possible -->
<rule ref="SlevomatCodingStandard.ControlStructures.RequireNullCoalesceEqualOperator"/>
<!-- Require usage of null safe operator when possible -->
<rule ref="SlevomatCodingStandard.ControlStructures.RequireNullSafeObjectOperator"/>
<!-- Require usage of ternary operator when possible -->
<rule ref="SlevomatCodingStandard.ControlStructures.RequireTernaryOperator">
<!-- But multiline is useful for readability -->
Expand Down Expand Up @@ -207,7 +213,7 @@
<severity>0</severity>
</rule>
<rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHint.MissingTraversableTypeHintSpecification">
<severity>0</severity>
<severity>9</severity>
</rule>
<!-- Require return type hints to be declared -->
<rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint">
Expand All @@ -217,8 +223,9 @@
</properties>
</rule>
<rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint.UselessAnnotation">
<severity>0</severity>
<severity>9</severity>
</rule>
<!-- TODO -->
<rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint.MissingTraversableTypeHintSpecification">
<severity>0</severity>
</rule>
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"source": "https://github.com/mayflower/mo4-coding-standard"
},
"require": {
"php": "~7.2 || ~8.0",
"php": "~7.4 || ~8.0",
"dealerdirect/phpcodesniffer-composer-installer": "~0.7",
"escapestudios/symfony2-coding-standard": "^3.10.0",
"slevomat/coding-standard": "^7.0.1",
Expand Down