Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#17] Improve S3-FIFO #18

Merged
merged 1 commit into from
Dec 12, 2023
Merged

[#17] Improve S3-FIFO #18

merged 1 commit into from
Dec 12, 2023

Conversation

maypok86
Copy link
Owner

@maypok86 maypok86 commented Dec 11, 2023

Description

  1. Added eviction of an item from the main queue at 20 reinsertions into the main queue.

  2. Performed a small refactoring of the algorithm

Related issue(s)

#17

✅ Checklist for your Pull Request

Related changes (conditional)

  • Tests

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from
      silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
  • Public contracts

    • My changes doesn't break project license.

Stylistic guide (mandatory)

  • My code complies with the styles guide.

  • My commit history is clean (only contains changes relating to my
    issue/pull request and no reverted-my-earlier-commit changes) and commit
    messages start with identifiers of related issues in square brackets.

    Example: [#42] Short commit description

    If necessary both of these can be achieved even after the commits have been
    made/pushed using rebase and squash.

Before merging (mandatory)

  • Check target branch of PR is set correctly

@codecov-commenter
Copy link

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (f1b9436) 82.64% compared to head (a71450d) 81.18%.
Report is 3 commits behind head on main.

Files Patch % Lines
cache.go 52.17% 19 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   82.64%   81.18%   -1.47%     
==========================================
  Files           9        9              
  Lines         657      691      +34     
==========================================
+ Hits          543      561      +18     
- Misses         99      115      +16     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maypok86 maypok86 merged commit a2d6643 into main Dec 12, 2023
8 checks passed
@maypok86 maypok86 deleted the maypok86/#17-s3fifo-impovements branch December 12, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants