added test + logic

mbta · Sep 14, 2023 · 3e9797a · 3e9797a
1 parent e79c9ef
commit 3e9797a
Show file tree

Hide file tree

Showing 2 changed files with 59 additions and 5 deletions.
diff --git a/apps/parse/lib/parse/alerts.ex b/apps/parse/lib/parse/alerts.ex
@@ -137,9 +137,14 @@ defmodule Parse.Alerts do
   end
 
   defp do_localized_image(%{"localized_image" => [_ | _] = translations}, %{default: default}) do
-    case Enum.find(translations, &(&1["language"] == "en")) do
-      %{"language" => "en", "url" => url} -> url
-      _ -> default
+    translations =
+      translations
+      |> Enum.filter(&(&1["language"] == "en" or &1["language"] == nil))
+      |> Enum.sort(:desc)
+
+    case length(translations) >= 1 do
+      true -> hd(translations)["url"]
+      false -> default
     end
   end
 

diff --git a/apps/parse/test/parse/alerts_test.exs b/apps/parse/test/parse/alerts_test.exs
@@ -436,7 +436,7 @@ defmodule Parse.AlertsTest do
       assert [%Alert{description: "Good morning"}] = parse_json(map)
     end
 
-    test "returns english image url over unspecified language" do
+    test "returns english image url over other language" do
       url =
         "https://dev-mbta.pantheonsite.io/sites/default/files/styles/max_2600x2600/public/media/2023-09/QuincyCenter-Braintree-EA.png"
 
@@ -461,6 +461,10 @@ defmodule Parse.AlertsTest do
                   "media_type" => "image/png",
                   "language" => "fr"
                 },
+                %{
+                  "url" => "some_other_url",
+                  "media_type" => "image/png"
+                },
                 %{
                   "url" => url,
                   "media_type" => "image/png",
@@ -482,7 +486,7 @@ defmodule Parse.AlertsTest do
       assert [%Alert{image: ^url}] = parse_json(map)
     end
 
-    test "returns english image url over other language" do
+    test "returns english image url over unspecified language" do
       url =
         "https://dev-mbta.pantheonsite.io/sites/default/files/styles/max_2600x2600/public/media/2023-09/QuincyCenter-Braintree-EA.png"
 
@@ -527,6 +531,51 @@ defmodule Parse.AlertsTest do
       assert [%Alert{image: ^url}] = parse_json(map)
     end
 
+    test "returns unspecified url over non-english language if english is not present" do
+      url =
+        "https://dev-mbta.pantheonsite.io/sites/default/files/styles/max_2600x2600/public/media/2023-09/QuincyCenter-Braintree-EA.png"
+
+      map = %{
+        "timestamp" => "1496832813",
+        "alerts" => [
+          %{
+            "active_period" => [],
+            "alert_lifecycle" => "NEW",
+            "cause" => "UNKNOWN_CAUSE",
+            "created_timestamp" => 1_494_947_991,
+            "description_text" => [],
+            "duration_certainty" => "KNOWN",
+            "effect" => "NO_SERVICE",
+            "effect_detail" => "STATION_CLOSURE",
+            "header_text" => [],
+            "id" => "113791",
+            "image" => %{
+              "localized_image" => [
+                %{
+                  "url" => "some_other_url",
+                  "media_type" => "image/png",
+                  "language" => "fr"
+                },
+                %{
+                  "url" => url,
+                  "media_type" => "image/png"
+                }
+              ]
+            },
+            "informed_entity" => [%{}],
+            "last_modified_timestamp" => 1_494_947_991,
+            "last_push_notification_timestamp" => 1_494_947_991,
+            "service_effect_text" => [],
+            "severity" => 3,
+            "short_header_text" => [],
+            "timeframe_text" => []
+          }
+        ]
+      }
+
+      assert [%Alert{image: ^url}] = parse_json(map)
+    end
+
     test "still returns image url even if no language specified" do
       url =
         "https://dev-mbta.pantheonsite.io/sites/default/files/styles/max_2600x2600/public/media/2023-09/QuincyCenter-Braintree-EA.png"