Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manually override stop ordering for green line branch merging #653

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

bfauble
Copy link
Contributor

@bfauble bfauble commented Jul 27, 2023

Summary of changes

Asana Ticket: TICKET_NAME

Current logic defaults to placing smaller branch after longer branch. In the case of Green-E/D the branch between Union Square/Medford and North station is considered a smaller branch than the remainder of the line and placed at the wrong end of the list. This is an explicit catch for this unique scenario and should not affect any others.

@bfauble bfauble requested a review from jfabi July 27, 2023 16:08
@github-actions
Copy link

Coverage of commit 5de0e99

Summary coverage rate:
  lines......: 89.6% (4022 of 4488 lines)
  functions..: 70.6% (2202 of 3121 functions)
  branches...: no data found

Files changed coverage rate:
                                                                        |Lines       |Functions  |Branches    
  Filename                                                              |Rate     Num|Rate    Num|Rate     Num
  ============================================================================================================
  apps/state/lib/state/stops_on_route.ex                                |93.2%    103|96.8%    31|    -      0

Download coverage report

@jfabi jfabi temporarily deployed to dev-blue July 27, 2023 16:16 — with GitHub Actions Inactive
@jfabi
Copy link
Member

jfabi commented Jul 27, 2023

@bfauble I just deployed this to dev-blue, and things seem to look good here 🎉—reconfigured the GTFS-creator branch and gave CI another run there. I'll wait to make sure it all passes (I anticipate it will), and then will give the ✅ approval here.

Copy link
Member

@jfabi jfabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 🎉 Thank you for all the spelunking you had to do to put this together. Here's to rebuilding our stops-on-route logic very soon!

@bfauble bfauble merged commit f9cb0c9 into master Jul 27, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants