Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add duration_certainty to AlertView #831

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

boringcactus
Copy link
Member

Summary of changes

Asana Ticket: 🍎 Surface 'duration_certainty' in v3 API

https://api-v3.mbta.com/alerts?fields[alert]=duration_certainty contains no actual duration_certainty values, because #828 was missing this piece. I've checked that this causes duration_certainty values to be returned.

Copy link

Coverage of commit 88d6e97

Summary coverage rate:
  lines......: 89.1% (4223 of 4740 lines)
  functions..: 71.0% (2261 of 3186 functions)
  branches...: no data found

Files changed coverage rate:
                                                                        |Lines       |Functions  |Branches    
  Filename                                                              |Rate     Num|Rate    Num|Rate     Num
  ============================================================================================================
  apps/api_web/lib/api_web/views/alert_view.ex                          | 100%     23|80.6%    62|    -      0

Download coverage report

@meagharty meagharty self-requested a review September 27, 2024 19:38
Copy link

github-actions bot commented Oct 1, 2024

Coverage of commit 9808fd8

Summary coverage rate:
  lines......: 89.1% (4224 of 4740 lines)
  functions..: 71.0% (2261 of 3186 functions)
  branches...: no data found

Files changed coverage rate:
                                                                        |Lines       |Functions  |Branches    
  Filename                                                              |Rate     Num|Rate    Num|Rate     Num
  ============================================================================================================
  apps/api_web/lib/api_web/views/alert_view.ex                          | 100%     23|80.6%    62|    -      0

Download coverage report

@boringcactus boringcactus merged commit a03a490 into master Oct 1, 2024
6 checks passed
@boringcactus boringcactus deleted the mth-duration-certainty branch October 1, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants