fix: check correct ETS table for stop state last updated #836
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: 🍎 Look into /stops updating too frequently in v3 API /status endpoint
Upon examination, it turned out that the
Stop
state is implemented a bit differently from most of the other states, in that the process that actuallyuse
-esState.Server
and tracks the state in an ETS table isn'tState.Stop
butState.Stop.Cache
. TheState.Metadata.last_updates/1
function returns the result ofDateTime.utc_now/0
if no timestamp is found in ETS, so because we were looking for the last updated time of the wrong module we were always getting the current time.