cleanup(ex/test): general cleanup related to upgrading to the latest Phoenix version and Template #2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firestack
force-pushed
the
kf/update/phoenix/test-misc
branch
3 times, most recently
from
48c165b
to
e23285e
Compare
firestack
commented
Oct 21, 2024
Comment on lines
+52
to
+53
| Regex.replace(~r"%{(\w+)}", message, fn _, key -> | ||
| opts |> Keyword.get(String.to_existing_atom(key), key) |> to_string() |
There was a problem hiding this comment.
Dunno much about this change, but I don't think we use this function yet.
firestack
force-pushed
the
kf/update/phoenix/test-misc
branch
from
e23285e
to
5525511
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewable by commit for more info.