android: persistent settings #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcastorina
reviewed
Jul 22, 2021
Comment on lines
43
to
47
| BackgroundToggleButton subtitles2 = (miccah.mpvremote.BackgroundToggleButton) | ||
| findViewById(R.id.subtitles2); | ||
| subtitles2.setChecked(PreferenceManager.getDefaultSharedPreferences(this) | ||
| .getBoolean("SUBTITLES", true)); | ||
|
|
There was a problem hiding this comment.
What is this code doing? Where is the subtitles2 view defined?
There was a problem hiding this comment.
No worries, I see it's getting the SUBTITLES preference here but I'm not seeing where it gets set.
There was a problem hiding this comment.
my bad, I got it into another branch by mistake
|
Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds saving & restoring for the settings: subtitles toggle state, IP address, port & password. The saved states are read on startup and are saved everytime they are modified and applied/lose focus.
For the IP if no IP address is already saved (i.e. at first run) or is set to an empty string or app storage was cleared then the usual procedure of default IP prefix construction and scan is done. This still allows people to utilize them on first run.
#34