Skip to content

Commit

Permalink
Fix #196: -Wunused-parameter warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
terrillmoore committed Jun 14, 2022
1 parent 5d900f3 commit e5545df
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 3 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,7 @@ Much more elaborate uses can be found in the MCCI [Catena-Arduino-Platform](http
- Head includes the following changes.
- Fix `-Wunused-parameter` warnings from gcc. ([#196](https://github.com/mcci-catena/arduino-lorawan/issues/196)). This is v0.9.2-pre3.
- Apply pre-release version to `library.properties` and `library.json` ([#195](https://github.com/mcci-catena/arduino-lorawan/issues/195)). This is v0.9.2-pre2.
- Correct error, missing `return true` at end of `Arduino_LoRaWAN::ApplySessionState()`. ([#194])(https://github.com/mcci-catena/arduino-lorawan/issues/194)).
- Correct error in logging, missing `return true` in `Arduino_LoRaWAN::cEventLog::processSingleEvent()` ([#191](https://github.com/mcci-catena/arduino-lorawan/issues/191)). This is v0.9.2-pre1.
Expand Down
2 changes: 1 addition & 1 deletion library.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"authors": ["Terry Moore <[email protected]>"]
}
],
"version": "0.9.2-pre2",
"version": "0.9.2-pre3",
"frameworks": "arduino",
"platforms": "*"
}
2 changes: 1 addition & 1 deletion library.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name=MCCI Arduino LoRaWAN Library
version=0.9.2-pre2
version=0.9.2-pre3
author=Terry Moore, ChaeHee Won
maintainer=Terry Moore <[email protected]>
sentence=High-level library for LoRaWAN-based Arduino end-devices.
Expand Down
10 changes: 9 additions & 1 deletion src/Arduino_LoRaWAN.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Copyright notice:
/// \ref ARDUINO_LORAWAN_VERSION_COMPARE_LT() to compare relative versions.
///
#define ARDUINO_LORAWAN_VERSION \
ARDUINO_LORAWAN_VERSION_CALC(0, 9, 2, 2) /* v0.9.2-pre2 */
ARDUINO_LORAWAN_VERSION_CALC(0, 9, 2, 3) /* v0.9.2-pre3 */

#define ARDUINO_LORAWAN_VERSION_GET_MAJOR(v) \
(((v) >> 24u) & 0xFFu)
Expand Down Expand Up @@ -844,6 +844,10 @@ class Arduino_LoRaWAN
size_t nExtraSessionInfo
)
{
MCCIADK_API_PARAMETER(SessionInfo);
MCCIADK_API_PARAMETER(pExtraSessionInfo);
MCCIADK_API_PARAMETER(nExtraSessionInfo);

// default: do nothing.
}

Expand All @@ -854,6 +858,8 @@ class Arduino_LoRaWAN
SessionState &State
)
{
MCCIADK_API_PARAMETER(State);

// default: not implemented.
return false;
}
Expand All @@ -866,6 +872,8 @@ class Arduino_LoRaWAN
const SessionState &State
)
{
MCCIADK_API_PARAMETER(State);

// default: do nothing.
}

Expand Down

0 comments on commit e5545df

Please sign in to comment.