Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ff111 More OPFS related updaes #19056

Merged
merged 7 commits into from
Mar 13, 2023
Merged

Ff111 More OPFS related updaes #19056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4d848ad
FF111 FileSystemFileHandle
hamishwillee Mar 6, 2023
fafa407
FF111 api/FileSystemFileHandle
hamishwillee Mar 6, 2023
e010bce
FF111 api/FileSystemHandle
hamishwillee Mar 6, 2023
b11d4d1
FF111 api/FileSystemSyncAccessHandle
hamishwillee Mar 6, 2023
96666bb
FF111 api/FileSystemWritableFileStream
hamishwillee Mar 6, 2023
8253d79
FileSystemHandle -revert things not supported by Firefox
hamishwillee Mar 6, 2023
d407dcb
FF111 supports non-standard FileSystemHandle.move()
hamishwillee Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions api/FileSystemDirectoryHandle.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down Expand Up @@ -48,7 +48,7 @@
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down Expand Up @@ -86,7 +86,7 @@
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down Expand Up @@ -124,7 +124,7 @@
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down Expand Up @@ -162,7 +162,7 @@
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down Expand Up @@ -200,7 +200,7 @@
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down Expand Up @@ -238,7 +238,7 @@
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down Expand Up @@ -276,7 +276,7 @@
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down Expand Up @@ -313,7 +313,7 @@
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down
8 changes: 4 additions & 4 deletions api/FileSystemFileHandle.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down Expand Up @@ -48,7 +48,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down Expand Up @@ -82,7 +82,7 @@
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down Expand Up @@ -120,7 +120,7 @@
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down
41 changes: 37 additions & 4 deletions api/FileSystemHandle.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
hamishwillee marked this conversation as resolved.
Show resolved Hide resolved
},
"firefox_android": "mirror",
"ie": {
Expand Down Expand Up @@ -48,7 +48,7 @@
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down Expand Up @@ -86,7 +86,7 @@
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand All @@ -113,6 +113,39 @@
}
}
},
"move": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/FileSystemHandle/move",
"support": {
"chrome": {
"version_added": false
},
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
"version_added": false
},
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": false
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror"
},
"status": {
"experimental": true,
"standard_track": false,
"deprecated": false
}
}
},
Comment on lines +116 to +148
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@queengooborg FYI support for this was added in FF111 in https://bugzilla.mozilla.org/show_bug.cgi?id=1811001. However appears to be explicitly non-standard at this point as it is in a "PR" state - see the big banner when you access the URL https://whatpr.org/fs/10.html#api-filesystemhandle

Upshot, I've added it because that makes the compatibility story easier to track later, but there is no spec URL and it is marked as experimental and non-standard.

@saschanaz Added with above caveats ^^^. I don't plan to add documentation for this right now; any idea on when this PR is likely to go in?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea, maybe @janvarga knows?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saschanaz - cool - not urgent - just useful so we get a ping when it becomes standard.

BTW, thanks for all your help and advice on this. I will do better next time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, you're welcome 👍

"name": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/FileSystemHandle/name",
Expand All @@ -124,7 +157,7 @@
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down
30 changes: 15 additions & 15 deletions api/FileSystemSyncAccessHandle.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down Expand Up @@ -48,7 +48,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down Expand Up @@ -89,7 +89,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand All @@ -106,7 +106,7 @@
"webview_android": "mirror"
},
"status": {
"experimental": true,
"experimental": false,
"standard_track": true,
"deprecated": false
}
Expand All @@ -126,7 +126,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down Expand Up @@ -167,7 +167,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand All @@ -184,7 +184,7 @@
"webview_android": "mirror"
},
"status": {
"experimental": true,
"experimental": false,
"standard_track": true,
"deprecated": false
}
Expand All @@ -204,7 +204,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down Expand Up @@ -245,7 +245,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand All @@ -262,7 +262,7 @@
"webview_android": "mirror"
},
"status": {
"experimental": true,
"experimental": false,
"standard_track": true,
"deprecated": false
}
Expand All @@ -282,7 +282,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down Expand Up @@ -318,7 +318,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down Expand Up @@ -359,7 +359,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand All @@ -376,7 +376,7 @@
"webview_android": "mirror"
},
"status": {
"experimental": true,
"experimental": false,
"standard_track": true,
"deprecated": false
}
Expand All @@ -396,7 +396,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand Down
16 changes: 8 additions & 8 deletions api/FileSystemWritableFileStream.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand All @@ -30,7 +30,7 @@
"webview_android": "mirror"
},
"status": {
"experimental": true,
"experimental": false,
"standard_track": true,
"deprecated": false
}
Expand All @@ -48,7 +48,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand All @@ -65,7 +65,7 @@
"webview_android": "mirror"
},
"status": {
"experimental": true,
"experimental": false,
"standard_track": true,
"deprecated": false
}
Expand All @@ -84,7 +84,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand All @@ -101,7 +101,7 @@
"webview_android": "mirror"
},
"status": {
"experimental": true,
"experimental": false,
"standard_track": true,
"deprecated": false
}
Expand All @@ -120,7 +120,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": false
"version_added": "111"
},
"firefox_android": "mirror",
"ie": {
Expand All @@ -137,7 +137,7 @@
"webview_android": "mirror"
},
"status": {
"experimental": true,
"experimental": false,
"standard_track": true,
"deprecated": false
}
Expand Down