Ff125 shadowroot serializable #23088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
data:api 🐇
hamishwillee
commented
May 14, 2024
| @@ -2627,9 +2627,10 @@ | |||
| "deprecated": false | |||
| } | |||
| }, | |||
| "init_clonable_parameter": { | |||
| "options_clonable_parameter": { | |||
There was a problem hiding this comment.
Note, changed these to options, because that is what the MDN docs use. I'd be OK with since these are "initialize the shadow root" but options is more common.
There was a problem hiding this comment.
Yeah options is more common. I suspect this comes from the IDL which uses init rather than options. 🤷
hamishwillee
commented
May 14, 2024
| @@ -2700,6 +2702,41 @@ | |||
| "deprecated": false | |||
| } | |||
| } | |||
| }, | |||
| "options_serializable_parameter": { | |||
There was a problem hiding this comment.
This is new one added in Chrome 125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome 125 adds support for serialiable shadow roots in https://chromestatus.com/feature/5102952270528512 - most of this has been caught before, but we were missing some init values and values for setting this in declaratively created shadow roots.
This is part of mdn/content#32731