Fix small bug with non-constant density contrast #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update update_prisms_ds for dealing with non-constant density contrast
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
- Coverage 37.86% 37.40% -0.47%
==========================================
Files 8 8
Lines 1537 1556 +19
==========================================
Hits 582 582
- Misses 955 974 +19 ☔ View full report in Codecov by Sentry. |
…ract contrast instead BREAKING CHANGE: the `run_inversion` function now doesn't take `density_contrast` parameter, please remove these parameters from your code!
…sm layer instead BREAKING_CHANGE: make sure to remove all `zref` and `density_contrast` parameters from the following functions: run_inversion, grav_cv_score, constraints_cv_score.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
update_prisms_dsfor dealing with non-constant density contrast #77