use env var instead

medialab · Dec 13, 2022 · 445b70e · 445b70e
1 parent 0524022
commit 445b70e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -29,7 +29,7 @@ jobs:
         run: npm run build:all
 
       - name: Package electron app in different versions and architectures 🔧
-        run: npm run package --version=${{ github.ref_name }}
+        run: VERSION=${{ github.ref_name }} npm run package
 
       - name: Check builds dir
         run: ls release dist

diff --git a/package.json b/package.json
@@ -15,7 +15,7 @@
     "dev:serve": "electron .",
     "start": "cross-env NODE_ENV=production electron .",
     "build:all": "cross-env NODE_ENV=production node bin/package.js",
-    "package": "cd release/ && ls | while read d; do cd $d; rm -f *.zip; zip -r HyBro-${npm_config_version}-$d.zip *; cd ..; done && mv */*.zip .",
+    "package": "cd release/ && ls | while read d; do cd $d; rm -f *.zip; zip -r HyBro-$VERSION-$d.zip *; cd ..; done && mv */*.zip .",
     "release": "npm run build:all && npm run package",
     "build": "cross-env NODE_ENV=production webpack --config webpack.config.production.js --progress --profile --colors",
     "watch:dev-server": "cross-env NODE_ENV=development webpack-dashboard",