Coverity fix: pointer/resource leak #223
Conversation
ZitaLiao
changed the title
ZitaLiao
changed the title
harryz2000
changed the title
|
@harryz2000 could we try to use |
|
Yes. That would be a good idea. Will make the change. |
harryz2000
changed the title
src/mp4streamer.cpp
Outdated
| @@ -996,7 +996,7 @@ AVCDescriptor* MP4Streamer::GetAVCDescriptor() | |||
| if (pictureHeaderSize) | |||
| free(pictureHeaderSize); | |||
|
|
|||
| return desc; | |||
| return desc.release(); | |||
There was a problem hiding this comment.
let's make MP4Streamer::GetAVCDescriptor() return a std::unique_ptr and chante the rtmpmp4streamer to use a unique ptr too
src/mp4recorder.cpp
Outdated
| //Add it to map | ||
| videoTrack = videoTrackPtr.release(); |
There was a problem hiding this comment.
I think that we should modernize the whole pointer management of the tracks. So let's change the videoTracks to be a vector of shared_ptrs and use shared_ptrs instead of unique_ptrs for videoTrack so the code here is easier to change
| @@ -130,7 +130,7 @@ void RTMPMP4Stream::doPlay(QWORD transId, std::wstring& url,RTMPMediaStream::Lis | |||
| SendMetaData(meta); | |||
|
|
|||
| //Get AVC descriptor if any | |||
| desc = streamer.GetAVCDescriptor(); | |||
| desc = streamer.GetAVCDescriptor().release(); | |||
There was a problem hiding this comment.
can we make desc in in RTMPMP4Stream a unique ptr too?
There was a problem hiding this comment.
It seems this rtmpmp4stream.cpp wasn't used in any build files. Therefore, I tended to do minor changes in case the change would break anything. So I didn't optimize this file. Where was this file used? Or should we optimize it anyway? If so, we might want to add it to some cmake file to at least verify it can compile.
There was a problem hiding this comment.
ok, let's ignore it for now.
No description provided.