Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent duplication of candidates with same remote ip:port #242

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

murillo128
Copy link
Member

No description provided.

@mildsunrise
Copy link
Contributor

context for anyone who's reading this:

#236 was incomplete because I was only checking candidates added through the JS interface. this PR fixes that and checks candidates learnt by the ICE layer itself, too. but the return also fixes an older memory safety issue that would occur if we called ActivateRemoteCandidate on a connection/transport that does not own the candidate, as the candidate could eventually be removed and this transport would still hold a (dangling) reference to it through its active candidate pointer.

Copy link
Contributor

@mildsunrise mildsunrise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@murillo128 murillo128 merged commit 191f784 into master Jan 23, 2024
1 check failed
@mildsunrise mildsunrise deleted the dev/sergio/ice-candidate-steal branch January 23, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants