-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Modify audio codec API to use AudioBuffer #335
Conversation
In order to be able to progress this PR, can we split it in two PRs? The first one about method changes to use the AudioBuffer and the second one to fix the timestamp calculation inside the AudioPipe? |
@murillo128 @bcostdolby I have updated the implementation to use a queue of audio buffers in audio pipe, and also added timestamp calculation for audio buffer based on decoder pts. if we all like this approach better, i will clean up the code a bit in my next commit. This version still has |
f889cf5
to
7bdc6ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking better, still some changes I would like to make
f11de4c
to
b6423bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What's included in this PR:
Timestamp improvement will be included in next PR.