Use exception rather than assertion for parsing data #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcostdolby
reviewed
Sep 13, 2024
| @@ -39,7 +39,8 @@ class BitReader | |||
|
|
|||
| inline DWORD Get(DWORD n) | |||
| { | |||
| assert(n <= 32); | |||
| if (n > 32) | |||
There was a problem hiding this comment.
I prefer this, but it means that someone is calling Get() asking for more bits of data than are possible to fit in the DWORD. I.e. Is a bug in the caller really which assert() is theoretically correct for.
There was a problem hiding this comment.
I don't think we should be that strict. Passing n shouldn't be illegal but just invalid. The argument could be from data not from our manual input. So I don't think calling it with a value more than 32 is a bug. If we use assert, we must check it before passing it to this Get() function, which would be not convenient and I think that is against our intention to use exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.