feat: introduce rbsp unscaping buffer reader #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murillo128
changed the title
eck1001
reviewed
Sep 17, 2024
eck1001
reviewed
Sep 17, 2024
| this->pos = 0; | ||
| } | ||
|
|
||
| inline bool Assert(size_t num) const |
There was a problem hiding this comment.
What are we asserting here?
Is this method used to skip the input NAL for a h26x buffer?
There was a problem hiding this comment.
this method is used to ensure that we have enough bytes to call PeekX method safely, we probably want to replace them with exceptions eventually.
Note that this RbspReader as the same methods as the BufferReader so we can use them as template input for the BaseBitReader
mildsunrise
approved these changes
Sep 17, 2024
Co-authored-by: Alba Mendez <[email protected]>
|
thanxs for your reivews! yes, it is sad that I had to copy the same code in 3 places, couldn't find any good idea for cleaning it up, any idea on ow to improve it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
completely untested, ptal