Improve __repr__ and Viewbox #117
Merged
Commits on Aug 13, 2021
-
1. Viewbox `init` now handles various forms of arguments so it can recreate from a repr: * "x y w h" * x=x etc. 2. Viewbox creates a correct better `repr`. 3. SVGImage adds missing attributes, puts the href (which is potentially huge) last and (I hope this is correct) puts the href attribute in quotations so that the end is easily parseable. -
-
SVG attribute is preserveAspectRatio
Since `**kwargs` are often converted using attribute name, we need to use `preserveAspectRatio` everywhere instead of `preserve_aspect_ratio`. We also need to convert "none" to `None`.
-
-
-
Commits on Aug 18, 2021
Commits on Aug 20, 2021
-
-
-
Remove image_width/height from repr
These are NOT part of the SVG 2.0 spec.
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.