Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vagrant file to newer config syntax with Ubuntu VirtualBox internet fix #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bennlich
Copy link

@robert-chiniquy
Copy link

Thanks for this change.

I'm assuming this config syntax isn't compatible backwards to older versions of Vagrant.

Also wondering why specifically the NAT DNS flags are needed. Is this specific to a network context (like a network without DHCP)? Or is it related to how the guest DNS client interfaces with the host?

@bennlich
Copy link
Author

bennlich commented Dec 5, 2013

You are right--this config syntax is compatible with vagrant 1.1+, but not
1.0.x. It might make sense to undo my change so that it remains compatible
with older versions (not sure if the Vagrant.configure("2") line would be
ignored or cause errors in 1.0.x). More on configuration in different
versions here: http://docs.vagrantup.com/v2/vagrantfile/version.html.

I don't think the NAT DNS flags are specific to a network context (my home
network does use DHCP), but I don't really know why they are necessary or
what they do. Take a look at
hashicorp/vagrant#1807 for more people using this
as a solution. Maybe the flag should be commented out by default, with a
note in the readme somewhere?

On Thu, Dec 5, 2013 at 8:11 AM, Robert Chiniquy [email protected]:

Thanks for this change.

I'm assuming this config syntax isn't compatible backwards to older
versions of Vagrant.

Also wondering why specifically the NAT DNS flags are needed. Is this
specific to a network context (like a network without DHCP)? Or is it
related to how the guest DNS client interfaces with the host?


Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-29911000
.

@robert-chiniquy
Copy link

I'll try this in 1.0.x when I get a chance to see if we can leave it as-is.

Unfortunately, the heuristic for when to enable/disable this is really just... not strong. I don't know the cases when internet is slow.

If @mitchellh can't figure this out, I won't expect to. I'm not sure what the possible downsides of these flags are. I think you're right, commented by default with a link to the vagrant issue for context.

@mitchellh
Copy link

Also, for backwards compat, you can just do Vagrant::Config.run. Both 1.0 and 1.1+ understand that as a V1 config block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants