Skip to content

Commit

Permalink
Merge #117
Browse files Browse the repository at this point in the history
117: Fix ingress does not contain a valid IngressClass r=alallema a=beshkenadze

Add the ingressClassName field  if the k8s version higher then 1.19-0.

See: https://kubernetes.github.io/ingress-nginx/#what-is-an-ingressclass-and-why-is-it-important-for-users-of-ingress-nginx-controller-now

# Pull Request

## What does this PR do?
Fixes #116

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Aleksandr Beshkenadze <[email protected]>
  • Loading branch information
bors[bot] and beshkenadze authored May 25, 2022
2 parents a1b6291 + 037fe96 commit 224d5f8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/meilisearch/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v1
appVersion: "v0.27.1"
description: A Helm chart for the Meilisearch search engine
name: meilisearch
version: 0.1.33
version: 0.1.34
icon: https://res.cloudinary.com/meilisearch/image/upload/v1597822872/Logo/logo_img.svg
home: https://github.com/meilisearch/meilisearch-kubernetes/charts
maintainers:
Expand Down
3 changes: 3 additions & 0 deletions charts/meilisearch/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ metadata:
{{- . | toYaml | nindent 4 }}
{{- end }}
spec:
{{- if semverCompare ">=1.19-0" .Capabilities.KubeVersion.GitVersion -}}
ingressClassName: nginx
{{- end }}
{{- if .Values.ingress.tls }}
tls:
{{- range .Values.ingress.tls }}
Expand Down

0 comments on commit 224d5f8

Please sign in to comment.