Merge #113

113: Add loadBalancerIP and externalTrafficPolicy support for service r=alallema a=agodard # Pull Request ## What does this PR do? Fixes #112 : Add `service.loadBalancerIP` and `service.externalTrafficPolicy` optional chart values to configure meilisearch kubernetes service with custom IP address from IaaS. Co-authored-by: agodard <[email protected]>
meilisearch · May 19, 2022 · 8031b21 · 8031b21
2 parents 0c9c9e7 + 1e8f546
commit 8031b21
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/charts/meilisearch/Chart.yaml b/charts/meilisearch/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v1
 appVersion: "v0.27.0"
 description: A Helm chart for the Meilisearch search engine
 name: meilisearch
-version: 0.1.30
+version: 0.1.31
 icon: https://res.cloudinary.com/meilisearch/image/upload/v1597822872/Logo/logo_img.svg
 home: https://github.com/meilisearch/meilisearch-kubernetes/charts
 maintainers:

diff --git a/charts/meilisearch/README.md b/charts/meilisearch/README.md
@@ -82,6 +82,10 @@ helm uninstall <your-service-name>
 | | |
 | `service.type`                   | Kubernetes Service type                                        | `ClusterIP`
 | | |
+| `service.externalTrafficPolicy`  | Service external traffic policy                                | `-` (No external traffic policy)
+| | |
+| `service.loadBalancerIP`         | Service load balancer IP                                       | `-` (No load balancer IP)
+| | |
 | `service.annotations`            | Additional annotations for service                             | `{}`
 | | |
 | `persistence.enabled`            | Enable persistence using PVC                                   | `false`

diff --git a/charts/meilisearch/templates/service.yaml b/charts/meilisearch/templates/service.yaml
@@ -15,7 +15,13 @@ metadata:
     {{ toYaml . | nindent 4 }}
   {{- end }}
 spec:
+  {{- if .Values.service.externalTrafficPolicy }}
+  externalTrafficPolicy: {{.Values.service.externalTrafficPolicy}}
+  {{- end }}
   type: {{ .Values.service.type }}
+  {{- if .Values.service.loadBalancerIP }}
+  loadBalancerIP: {{.Values.service.loadBalancerIP}}
+  {{- end }}
   ports:
     - port: {{ .Values.service.port }}
       targetPort: http